Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refine GPRs for Pyrroline-5-carboxylate reductase #509

Merged
merged 2 commits into from
Mar 23, 2023
Merged

fix: refine GPRs for Pyrroline-5-carboxylate reductase #509

merged 2 commits into from
Mar 23, 2023

Conversation

haowang-bioinfo
Copy link
Member

@haowang-bioinfo haowang-bioinfo commented Mar 22, 2023 •
edited
Loading

Main improvements in this PR:

This PR improves GPRs of Pyrroline-5-carboxylate reductase as below (according to #505), and rename MAM01939 (#500)
MAR03833: PYCR2 or PYCRL
MAR03835: PYCR2 or PYCRL
MAR03837: PYCR1 or PYCR2
MAR08609: PYCR1 or PYCR2

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@haowang-bioinfo haowang-bioinfo mentioned this pull request Mar 22, 2023
Closed
mihai-sysbio
mihai-sysbio approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@mihai-sysbio mihai-sysbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Noting that this solves only a part of #505.

@haowang-bioinfo
Copy link
Member Author

haowang-bioinfo commented Mar 23, 2023 •
edited
Loading

you are absolutely right, this PR solves only a part of #505 that may need more time to reach a consensus.

@haowang-bioinfo haowang-bioinfo merged commit aa37637 into develop Mar 23, 2023
@haowang-bioinfo haowang-bioinfo deleted the fix/refineP5CGPRs branch March 23, 2023 20:31
@haowang-bioinfo haowang-bioinfo mentioned this pull request May 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihai-sysbio mihai-sysbio mihai-sysbio approved these changes

@feiranl feiranl Awaiting requested review from feiranl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haowang-bioinfo @mihai-sysbio